Revues de code

Correctifs appliqués

Bruce Momjian a poussé :

Tom Lane a poussé :

  • Fix copyright notices, other minor editing in new range-types code. No functional changes in this commit (except I could not resist the temptation to re-word a couple of error messages). This is just manual cleanup after pgindent to make the code look reasonably like other PG code, in preparation for more detailed code review to come. http://git.postgresql.org/pg/commitdiff/f1585362856d4da17113ba2e4ba46cf83cba0cf2
  • Return FALSE instead of throwing error for comparisons with empty ranges. Change range_before, range_after, range_adjacent to return false rather than throwing an error when one or both input ranges are empty. The original definition is unnecessarily difficult to use, and also can result in undesirable planner failures since the planner could try to compare an empty range to something else while deriving statistical estimates. (This was, in fact, the cause of repeatable regression test failures on buildfarm member jaguar, as well as intermittent failures elsewhere.) Also tweak rangetypes regression test to not drop all the objects it creates, so that the final state of the regression database contains some rangetype objects for pg_dump testing. http://git.postgresql.org/pg/commitdiff/851c83fc81917c61b063c875fc1bca489dfcc482
  • Return NULL instead of throwing error when desired bound is not available. Change range_lower and range_upper to return NULL rather than throwing an error when the input range is empty or the relevant bound is infinite. Per discussion, throwing an error seems likely to be unduly hard to work with. Also, this is more consistent with the behavior of the constructors, which treat NULL as meaning an infinite bound. http://git.postgresql.org/pg/commitdiff/4f9e33063cea270166fba12d89fe49876f814398
  • Update oidjoins regression test to match git HEAD. This is mostly to add some sanity checking for the pg_range catalog. http://git.postgresql.org/pg/commitdiff/4165d5b6d7d2e399edbc6d027039358794aa8f04
  • Fix alignment and toasting bugs in range types. A range type whose element type has 'd' alignment must have 'd' alignment itself, else there is no guarantee that the element value can be used in-place. (Because range_deserialize uses att_align_pointer which forcibly aligns the given pointer, violations of this rule did not lead to SIGBUS but rather to garbage data being extracted, as in one of the added regression test cases.) Also, you can't put a toast pointer inside a range datum, since the referenced value could disappear with the range datum still present. For consistency with the handling of arrays and records, I also forced decompression of in-line-compressed bound values. It would work to store them as-is, but our policy is to avoid situations that might result in double compression. Add assorted regression tests for this, and bump catversion because of fixes to built-in pg_type entries. Also some marginal cleanup of inconsistent/unnecessary error checks. http://git.postgresql.org/pg/commitdiff/ad50934eaadb626de682defe0ad270bbf31e92a2
  • Restructure function-internal caching in the range type code. Move the responsibility for caching specialized information about range types into the type cache, so that the catalog lookups only have to occur once per session. Rearrange APIs a bit so that fn_extra caching is actually effective in the GiST support code. (Use of OidFunctionCallN is bad enough for performance in itself, but it also prevents the function from exploiting fn_extra caching.) The range I/O functions are still not very bright about caching repeated lookups, but that seems like material for a separate patch. Also, avoid unnecessary use of memcpy to fetch/store the range type OID and flags, and don't use the full range_deserialize machinery when all we need to see is the flags value. Also fix API error in range_gist_penalty --- it was failing to set *penalty for any case involving an empty range. http://git.postgresql.org/pg/commitdiff/37ee4b75db8f979da6d67ba153d068b012394b46
  • Improve caching in range type I/O functions. Cache the the element type's I/O info across calls, not only the range type's info. In passing, also clean up hash_range a bit more. http://git.postgresql.org/pg/commitdiff/04da3232907680caad3445928c97a246c626a14a
  • Code review for range-types catalog entries. Fix assorted infelicities, such as dependency on OIDs that aren't hardwired, as well as outright misdeclaration of daterange_canonical(), which resulted in crashes if you invoked it directly. Add some more regression tests to try to catch similar mistakes in future. http://git.postgresql.org/pg/commitdiff/4509033a00df5f49c42a21772d8d617efe83e549
  • Fix range_cmp_bounds for the case of equal-valued exclusive bounds. Also improve its comments and related regression tests. Jeff Davis, with some further adjustments by Tom Lane. http://git.postgresql.org/pg/commitdiff/bf4f96b5e264f1c0f5d8694f11c6f9f5b3132b3b
  • Extend the unknowns-are-same-as-known-inputs type resolution heuristic. For a very long time, one of the parser's heuristics for resolving ambiguous operator calls has been to assume that unknown-type literals are of the same type as the other input (if it's known). However, this was only used in the first step of quickly checking for an exact-types match, and thus did not help in resolving matches that require coercion, such as matches to polymorphic operators. As we add more polymorphic operators, this becomes more of a problem. This patch adds another use of the same heuristic as a last-ditch check before failing to resolve an ambiguous operator or function call. In particular this will let us define the range inclusion operator in a less limited way (to come in a follow-on patch). http://git.postgresql.org/pg/commitdiff/1a8b9fb5499d8646661a57edd3c88c3107622ff8
  • Declare range inclusion operators as taking anyelement not anynonarray. Use of anynonarray was a crude hack to get around ambiguity versus the array inclusion operators of the same names. My previous patch to extend the parser's type resolution heuristics makes that unnecessary, so use the more general declaration instead. This eliminates a wart that these operators couldn't be used with ranges over arrays, which are otherwise supported just fine. Also, mark range_before and range_after as commutator operators, per discussion with Jeff Davis. http://git.postgresql.org/pg/commitdiff/709aca59608395eef9ceb7dcb79fd9d03a0709ef
  • Do missed autoheader run for previous commit. http://git.postgresql.org/pg/commitdiff/f6438f66226e37851e11a93edebae0198a875100
  • Further review of range-types patch. Lots of documentation cleanup today, and still more type_sanity tests. http://git.postgresql.org/pg/commitdiff/a1a233af66ed14d225ac2d5e7948a5cc8ed2cde6
  • Avoid floating-point underflow while tracking buffer allocation rate. When the system is idle for awhile after activity, the "smoothed_alloc" state variable in BgBufferSync converges slowly to zero. With standard IEEE float arithmetic this results in several iterations with denormalized values, which causes kernel traps and annoying log messages on some poorly-designed platforms. There's no real need to track such small values of smoothed_alloc, so we can prevent the kernel traps by forcing it to zero as soon as it's too small to be interesting for our purposes. This issue is purely cosmetic, since the iterations don't happen fast enough for the kernel traps to pose any meaningful performance problem, but still it seems worth shutting up the log messages. The kernel log messages were previously reported by a number of people, but kudos to Greg Matthews for tracking down exactly where they were coming from. http://git.postgresql.org/pg/commitdiff/40d35036bb160d5724305454d41c68ab1637ee6f
  • Further code review for range types patch. Fix some bugs in coercion logic and pg_dump; more comment cleanup; minor cosmetic improvements. http://git.postgresql.org/pg/commitdiff/b985d48779146b7ba969b0963614ad7683589bc8

Robert Haas a poussé :

  • Don't elide blank lines when accumulating psql command history. This can change the meaning of queries, if the blank line happens to occur in the middle of a quoted literal, as per complaint from Tomas Vondra. Back-patch to all supported branches. http://git.postgresql.org/pg/commitdiff/ff4fd4bf53c5512427f8ecea08d6ca7777efa2c5
  • Restructure get_object_address() so it's safe against concurrent DDL. This gives a much better error message when the object of interest is concurrently dropped and avoids needlessly failing when the object of interest is concurrently dropped and recreated. It also improves the behavior of two concurrent DROP IF EXISTS operations targeted at the same object; as before, one will drop the object, but now the other will emit the usual NOTICE indicating that the object does not exist, instead of rolling back. As a fringe benefit, it's also slightly less code. http://git.postgresql.org/pg/commitdiff/b3ad5d02c9cd8a4c884cd78480f221afe8ce5590
  • Remove ancient downcasing code from procedural language operations. A very long time ago, language names were specified as literals rather than identifiers, so this code was added to do case-folding. But that style has ben deprecated for many years so this isn't needed any more. Language names will still be downcased when specified as unquoted identifiers, but quoted identifiers or the old style using string literals will be left as-is. http://git.postgresql.org/pg/commitdiff/67dc4eed42186ba6a2456578899bfd38d003201a
  • Further consolidation of DROP statement handling. This gets rid of an impressive amount of duplicative code, with only minimal behavior changes. DROP FOREIGN DATA WRAPPER now requires object ownership rather than superuser privileges, matching the documentation we already have. We also eliminate the historical warning about dropping a built-in function as unuseful. All operations are now performed in the same order for all object types handled by dropcmds.c. KaiGai Kohei, with minor revisions by me http://git.postgresql.org/pg/commitdiff/fc6d1006bda783cc002c61a5f072905849dbde4b

Michael Meskes a poussé :

Alvaro Herrera a poussé :

Simon Riggs a poussé :

Correctifs rejetés (à ce jour)

  • Pas de déception cette semaine :-)

Correctifs en attente

  • Yeb Havinga sent in two more revisions of the patch to add named parameters to cursor calls.
  • Greg Smith sent in another revision of the patch to restructure how core extensions are placed in the source tree.
  • Bruce Momjian sent in a patch to fix an infelicity between pg_dump and malloc.
  • Jaime Casanova sent in another revision of the patch to measure relation free space.
  • Shigeru HANADA sent in another revision of the patch to remove useless columns from the system catalog table entries associated with foreign tables.
  • Simon Riggs sent in a PoC patch to add group commit.
  • Andrew Dunstan sent in another revision of the patch to create distinctions in pg_dump/pg_restore among pre-data, data, and post-data as distinct entities.
  • Shigeru HANADA sent in another revision of the patch to make it possible for the server to push JOINs to the foreign server, along with infrastructure for same.
  • Greg Smith sent in another revision of the patch to allow displaying accumulated autovacuum cost.
  • Julien Tachoires sent in another revision of the patch to allow moving a table, its TOAST table, or both to a new tablespace.
  • Shigeru HANADA sent in a new flock of patches to enable a pgsql_fdw.
  • Scott Mead sent in two more revisions of a patch to introspect states that are "<IDLE> in transaction."
  • Laurenz Albe sent in two more revisions of a patch to allow disabling SSL compression.
  • KaiGai Kohei sent in another flock of patches refactoring DDL, one part of which (DROP) Robert Haas updated and committed.
  • KaiGai Kohei sent in another revision of the patch to allow object creation hooks, which sepgsql will eventually use.
  • Simon Riggs sent in a patch to optimize XLogInsert().
  • Robert Haas and Pavan Deolasee traded patches to implement a new refactor of the locking system called FlexLocks.
  • Peter Eisentraut sent in a patch for type privileges.
  • Josh Kupershmidt sent in a patch to fix an infelicity in psql's \ir feature.
  • Greg Smith sent in a revived version of an old patch to allow including a whole directory in postgresql.conf.
  • Greg Smith sent in a patch to add an "include if exists" directive in postgresql.conf.
  • Edward Muller sent in another revision of the patch to allow users to kill their own queries.
  • Zoltan Boszormenyi sent in a patch to allow FETCH read-ahead in ECPG.
  • Tom Lane sent in a patch to avoid losing column names in some cases.
  • Etsuro Fujita sent in another revision of the patch that makes it possible to collect statistics on FDW data, including an implementation for the CSV FDW.
  • Andres Freund sent in two revisions of a patch to collapse a long chain of "ifs" in eval_const_expressions_mutator into a "switch" statement.
  • KaiGai Kohei sent in another revision of the patch to add a permission check on SELECT INTO.
  • Andres Freund sent in a patch to allow the combination of (plan off, rewrite off) in EXPLAIN for benchmarking.