Revues de code

Correctifs appliqués

Bruce Momjian a poussé :

Tom Lane a poussé :

  • Change the naming convention for extension files to use double dashes. This allows us to have an unambiguous rule for deconstructing the names of script files and secondary control files, without having to forbid extension and version names from containing any dashes. We do have to forbid them from containing double dashes or leading/trailing dashes, but neither restriction is likely to bother anyone in practice. Per discussion, this seems like a better solution overall than the original design.
  • Convert contrib modules to use the extension facility. This isn't fully tested as yet, in particular I'm not sure that the "foo--unpackaged--1.0.sql" scripts are OK. But it's time to get some buildfarm cycles on it. sepgsql is not converted to an extension, mainly because it seems to require a very nonstandard installation process. Dimitri Fontaine and Tom Lane.
  • Avoid use of CREATE OR REPLACE FUNCTION in extension installation files. It was never terribly consistent to use OR REPLACE (because of the lack of comparable functionality for data types, operators, etc), and experimentation shows that it's now positively pernicious in the extension world. We really want a failure to occur if there are any conflicts, else it's unclear what the extension-ownership state of the conflicted object ought to be. Most of the time, CREATE EXTENSION will fail anyway because of conflicts on other object types, but an extension defining only functions can succeed, with bad results.
  • Assorted fixups for "unpackaged" conversion scripts. From first pass of testing. Notably, there seems to be no need for adminpack--unpackaged--1.0.sql because none of the objects that the old module creates would ever be dumped by pg_dump anyway (they are all in pg_catalog).
  • Support replacing MODULE_PATHNAME during extension script file execution. This avoids the need to find a way to make PGXS' rule insert the right thing. We'll just deprecate use of that hack for extensions.
  • More fixups for "unpackaged" conversion scripts.
  • Remove no-longer-needed special case hacks in MSVC build scripts.
  • Fix obsolete references to old-style contrib installation methods.
  • Small improvements to external-projects documentation.
  • Rearrange extension-related views as per recent discussion. The original design of pg_available_extensions did not consider the possibility of version-specific control files. Split it into two views: pg_available_extensions shows information that is generic about an extension, while pg_available_extension_versions shows all available versions together with information that could be version-dependent. Also, add an SRF pg_extension_update_paths() to assist in checking that a collection of update scripts provide sane update path sequences.
  • Fix MSVC build scripts for recent extension-related changes. Untested, but we'll soon see if the buildfarm likes this.
  • Rethink naming of contrib/intagg extension. Initially it was called int_aggregate after the old SQL file, but since the documentation just says "intagg" and that's also the directory name, let's conform to that instead.
  • Fix obsolete comment. Comment about MaxAllocSize was not updated when the TOAST-header macros were replaced in 8.3 "varvarlena" changes. Per report from Frederik Ramm.
  • Bring hstore's comment into line with style of other contrib comments. All the other ones that are primarily a new datatype say "data type for <purpose>", so make this one similar.
  • Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX. Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog, but failed to cover the possibility of pending trigger events at DROP time. (Before 8.4 we didn't even check the refcnt.) When the trigger events were eventually fired, you'd get "could not open relation with OID nnn" errors, as in recent report from strk. Better to throw a suitable error when the DROP is attempted. Also add a similar check in DROP INDEX. Back-patch to all supported branches.
  • Fix corner case for binary upgrade: extension functions in pg_catalog. Normally, pg_dump summarily excludes functions in pg_catalog from consideration. However, some extensions may create functions in pg_catalog (adminpack already does that, and extensions for procedural languages will likely do it too). In binary-upgrade mode, we have to dump such functions, or the extension will be incomplete after upgrading. Per experimentation with adminpack.
  • Add FOREACH IN ARRAY looping to plpgsql. (I'm not entirely sure that we've finished bikeshedding the syntax details, but the functionality seems OK.) Pavel Stehule, reviewed by Stephen Frost and Tom Lane.
  • Make a no-op ALTER EXTENSION UPDATE give just a NOTICE, not ERROR. This seems a bit more user-friendly.
  • Add backwards-compatible declarations of some core GIN support functions. These are needed to support reloading dumps of 9.0 installations containing contrib/intarray or contrib/tsearch2. Since not only regular dump/reload but binary upgrade would fail, it seems worth the trouble to carry these stubs for awhile. Note that the contrib opclasses referencing these functions will still work fine, since GIN doesn't actually pay any attention to the declared signature of a support function.
  • Fix bogus test for hypothetical indexes in get_actual_variable_range(). That function was supposing that indexoid == 0 for a hypothetical index, but that is not likely to be true in any non-toy implementation of an index adviser, since assigning a fake OID is the only way to know at EXPLAIN time which hypothetical index got selected. Fix by adding a flag to IndexOptInfo to mark hypothetical indexes. Back-patch to 9.0 where get_actual_variable_range() was added. Gurjeet Singh
  • Fix blatantly uninitialized variable in recent commit. Doesn't anybody around here pay attention to compiler warnings?
  • Fix contrib/pg_trgm to have smoother updates from 9.0. Take care of some loose ends in the update-from-unpackaged script, and apply some ugly hacks to ensure that it produces the same catalog state as the fresh-install script. Per discussion, this seems like a safer plan than having two different catalog states that both call themselves "pg_trgm 1.0", even if it's not immediately clear that the subtle differences would ever matter. Also, fix the stub function gin_extract_trgm() so that it works instead of just bleating. Needed because this function will get called during a regular dump and reload, if there are any indexes using its opclass. The user won't have an opportunity to update the extension till later, so telling him to do so is unhelpful.
  • Fix upgrade of contrib/btree_gist from 9.0. The initial version of the update-from-unpackaged script neglected to include the <> operators that were added to the opclasses during 9.1. To make this script produce the same final state as the regular install script, use the same ALTER OPERATOR FAMILY trick as in pg_trgm.
  • Fix upgrade of contrib/intarray and contrib/unaccent from 9.0. Take care of a couple of discrepancies between what you get from a fresh install and what the first-draft update-from-unpackaged scripts produced.
  • Fix upgrade of contrib/xml2 from 9.0. Update script was being sloppy about two functions that have been changed since 9.0.
  • Fix tsmatchsel() to account properly for null rows. ts_typanalyze.c computes MCE statistics as fractions of the non-null rows, which seems fairly reasonable, and anyway changing it in released versions wouldn't be a good idea. But then ts_selfuncs.c has to account for that. Failure to do so results in overestimates in columns with a significant fraction of null documents. Back-patch to 8.4 where this stuff was introduced. Jesper Krogh
  • One more hack to make contrib upgrades from 9.0 match fresh 9.1 installs. intarray and tsearch2 both reference core support functions in their GIN opclasses, and the signatures of those functions changed for 9.1. We added backwards-compatible pg_proc entries for the functions in order to allow 9.0 dump files to be restored at all, but that hack leaves the opclasses pointing at pg_proc entries different from what they'd point to if the contrib modules were installed fresh in 9.1. To forestall any possibility of future problems, fix the opclasses to match fresh installs via the expedient of direct UPDATEs on pg_amproc in the update-from-unpackaged scripts. (Yech ... but the alternatives are worse, or require far more effort than seems justified right now.) Note: updating pg_amproc is sufficient because there will be no pg_depend entries corresponding to these dependencies, since the referenced functions are all pinned.
  • Fix parallel pg_restore to handle comments on POST_DATA items correctly. The previous coding would try to process all SECTION_NONE items in the initial sequential-restore pass, which failed if they were dependencies of not-yet-restored items. Fix by postponing such items into the parallel processing pass once we have skipped any non-PRE_DATA item. Back-patch into 9.0; the original parallel-restore coding in 8.4 did not have this bug, so no need to change it. Report and diagnosis by Arnd Hannemann.
  • Un-break building with BTREE_BUILD_STATS. This has been broken for awhile, but not clear it's worth back-patching. Euler Taveira de Oliveira
  • Create the catalog infrastructure for foreign-data-wrapper handlers. Add a fdwhandler column to pg_foreign_data_wrapper, plus HANDLER options in the CREATE FOREIGN DATA WRAPPER and ALTER FOREIGN DATA WRAPPER commands, plus pg_dump support for same. Also invent a new pseudotype fdw_handler with properties similar to language_handler. This is split out of the "FDW API" patch for ease of review; it's all stuff we will certainly need, regardless of any other details of the FDW API. FDW handler functions will not actually get called yet. In passing, fix some omissions and infelicities in foreigncmds.c. Shigeru Hanada, Jan Urbanski, Heikki Linnakangas
  • Implement an API to let foreign-data wrappers actually be functional. This commit provides the core code and documentation needed. A contrib module test case will follow shortly. Shigeru Hanada, Jan Urbanski, Heikki Linnakangas
  • Add contrib/file_fdw foreign-data wrapper for reading files via COPY. This is both very useful in its own right, and an important test case for the core FDW support. This commit includes a small refactoring of copy.c to expose its option checking code as a separately callable function. The original patch submission duplicated hundreds of lines of that code, which seemed pretty unmaintainable. Shigeru Hanada, reviewed by Itagaki Takahiro and Tom Lane
  • Minor logic fix for new levenshtein implementation. Alexander Korotkov

Simon Riggs a poussé :

Robert Haas a poussé :

Peter Eisentraut a poussé :

Alvaro Herrera a poussé :

ITAGAKI Takahiro a poussé :

Magnus Hagander a poussé :

Correctifs rejetés (à ce jour)

  • Pas de déception cette semaine :-)

Correctifs en attente

  • ITAGAKI Takahiro sent in another revision of the patch to implement MULTISET.
  • Stephen Frost and Robert Haas traded revisions of the patch to allow logging the current role.
  • Marti Raudsepp sent in another revision of the patch which makes it so a key lock is only acquired for columns that can be referenced.
  • Heikki Linnakangas sent in another revision of the patch to add a FDW API for SQL/MED.
  • Thom Brown sent in a patch to make array_cat consistent with the || operator for arrays with respect to NULLs.
  • ITAGAKI Takahiro sent in another revision of the patch to implement transaction-scope advisory locks.
  • Kevin Grittner sent in two revisions of a patch to fix an issue with uninitialized structures from the SSI patch.
  • ITAGAKI Takahiro sent in another revision of the COPY ENCODING patch.
  • Per feedback from Heikki Linnakangas, Simon Riggs sent in a patch to add a server_name parameter, plus mechanism to send info from standby to master. This will help with synchronous replication.
  • YAMAMOTO Takashi sent in a patch to fix an issue with SSI.
  • Tom Lane sent in two versions of a patch to fix pg_tgrm's update-from-unpackaged script.
  • Mark Kirkwood sent in a WIP patch to allow the backend to constrain temporary file space.
  • Tom Lane sent in a WIP patch to update KNN-GiST.
  • Magnus Hagander sent in another revision of the patch to include pg_basebackup.
  • Robert Haas sent in a patch to fix an issue with an assertion failure on UNLOGGED VIEWs.
  • Simon Riggs sent in a patch to add server_name for synchronous replication.
  • Simon Riggs sent in anothre revision of the patch to allow for synchronous replication.
  • Radoslaw Smogura sent in a patch to add void_send and void_receive, used in COPY ... BINARY.